Related
This is a genuine 64bit LineageOS 14.1 ROM for the Elephone Trunk. It's the follow up to my previous CM13.1 ROM as discussed here:
https://forum.xda-developers.com/android/development/rom-cyanogenmod-13-0-elephone-trunk-t3394060
It can be used as a daily driver, all important features seem to be working, including:
Voice
Mobile Data
Audio
Bluetooth
Camera
WiFi
GPS
Please feel free to post any bug reports here.
XDA:DevDB Information
LineageOS 14.1 for Elephone Trunk, ROM for all devices (see above for details)
Contributors
ottmi
Source Code: https://github.com/ottmi/android_device_elephone_trunk
ROM OS Version: 7.x Nougat
ROM Kernel: Linux 3.10.x
Based On: LineageOS
Version Information
Status: Snapshot
Current Stable Version: 20180114
Stable Release Date: 2018-01-14
Created 2017-02-10
Last Updated 2018-01-14
Changelog
20180114
Upstream LineageOS changes, including December 2017 security patches
Fix camera recordings
20170811
Upstream LineageOS changes, including August 2017 security patches
Remove libwvm and use Crackling Widevine blobs instead
20170430
Upstream LineageOS changes
20170419
Update to latest LineageOS Upstream, including Android 7.1.2 merge & April Security Patches
Enable F2FS
Get rid of annoying selinux denials for setsched
Enable Pinner Service to pin key files in memory
20170409
Return to Crackling camera blobs to fix issues re-enable higher camera resolution
Disable backlight dimming in thermal-engine
Fix random reboots due to qcom subsystem crashes
20170314
Replace netmgrd by proper binary from ASUS Z00T
Pull camera blobs (mostly) from Google Seed
20170224
Fix crashes of the WCNSS subsystem
20170221
Fix GPS
20170220
Fix torchlight tile
Fix netmgrd crashes that caused mobile data to stop working
Remove ZRAM, LZ4, and Swap
Remove F2FS support
Replace Camera with Snap
Replace Browser with Gello
20170210
First beta
ottmi said:
20170210
First beta
Click to expand...
Click to collapse
@ottmi
Thanks for your work we were expecting. Installed the new rom L_OS 14.1 without difficulty using "TWRP-3.0.2-20161108-trunk.img" + open_gapps-arm64-7.1-pico-20170210.zip + SuperSU-v2.79-201612051815.zip. so far also works updating of installed apps after a thorough tour will let you know any bugs.
Thanks again and good work.
This afternoon I installed the new ROM.
@ottmi first thank you, a job well done. the first impression is really good, I believe that from this foundation will do a wonderful job.
bug:
- The flashlight does not work.
- Some animations are jerky.
Considerations:
The general flow is good, Wi-Fi reception OK
GPS OK
Camera improvements, noisy photos. The 8 megapixel resolution is not selectable.
Battery: I do not know, it takes time to understand.
Awesome first release! Was this a lot of work to get to this stage, @ottmi?
Looking forward to the next build with currently reported bugs addressed, which is when I'll jump into the testing.
Martin
@ottmi
after using for a couple of days the first version of the Rom L_OS 14.1 I consider still to be improved especially the battery life, the management of the status bar and especially the lack of advanced configurations. All this by referring to the Rom "RR-N-v5.8.0-20170115-peach" I have used for nearly a month without any problems and with several customization options although 32Bit. It would be interesting on your part to verify the basis of http://www.resurrectionremix.com/ development for our Trunk 64Bit. Thanks anyway for the wonderful work you are doing.
I'm sorry for my english.
Guys, you have to be more specific than that if you want me to fix problems: @Sampierdarena:
Which animations are jerky? Is this still the case after the 2nd reboot?
Was the 8MP selection available with CM13.1? I think this is a feature of the camera apk..
@josoft86:
What's wrong with the status bar?
Which advanced configuration options are you missing?
I know about the flashlight, this has been a problem already in CM13.1 and I never found a way to fix it properly.
Also there seem to be some issues with the 2nd SIM slot. I sometimes don't get a data connection with the 2nd SIM - the status shows LTE or HSDPA and connected but I don't get an IP address. This doesn't seem to be a problem with the 1st SIM card. Did anybody else witness this problem?
@ottmi
I try to be more precise:
The animations are jerky affect the output from applications. I partially solved with the trim.
The camera: using CameraFV5 you can choose 8 megapixels, I think you're right, the problem is the camera application stock.
The battery with this release has a shorter duration than 10%, I think it is normal with Android 7.1
Thanks again for your work.
@ottmi
perhaps you interpreted my little appropriate proposals, but I did not remotely affect your work but address it on what I thought was perhaps valid for your own product development. I enclose the examples on the configuration and status bar that I used with the Rom RR. Thanks for your work always appreciated and I hope that more and more continuous.
Guys, I'm about to donate my dead elephone trunk if anyone needs it.
it was in great condition but one day it just won't turn on anymore.
it showing charging process once connected to charger, but doesn't react on power button.
case and some other accessories such as spare new back cover can also be donated .
And thanks Ottmi and all other guys for this great rom that extending life of this device!
@ottmi
I do not know if you might be interested in helping you develop your wonderful work for our Trunk:
Reference: https://plus.google.com/communities/109352646351468373340
"Resurrection Remix (official)
ROM Release │ DEVS ONLY-DO NOT POST HERE
İmportant announcement & some good news
So a few days back we came to an important decision , and we went ahead and decided to merge Full OMS Support.
Yes many users will be happy , some will be upset but honestly it has been too long waiting for Lineage Theme Engine .
Anyhow the manifests will be updated soon and maintainers can push oms builds as official .
Thank you for being patient with us.
Now You can enjoy full OMS supported themes and themers can now officially support our ROM .
PS: users please wait for your maintainers to upload your builds
NO ETA.
If coming from a 5.8.0 build , please clean flash .You will run into issues with dirty flashes and help will not be provided in that scenario
Read before posting
https://plus.google.com/101154841950858558748/posts/RAuHneppoKa
Thank you for understanding
Happy flashing..
Sincerely
RR Team"
Sampierdarena said:
@ottmi
I try to be more precise:
The animations are jerky affect the output from applications. I partially solved with the trim.
The camera: using CameraFV5 you can choose 8 megapixels, I think you're right, the problem is the camera application stock.
The battery with this release has a shorter duration than 10%, I think it is normal with Android 7.1
Click to expand...
Click to collapse
Can you name an application that shows the video problems?
Regarding the camera: the next ROM will ship with the new Snap app as stock camera that allows for setting the resolution to 7.7MP. I'm not sure thought whether that is native or will be interpolated from 13MP..
I can't really comment on battery life as I'm currently using the phone more intensive than usual and connect it to the computer very often, so the battery will recharge quite often..
@ josoft86:
Since the Ark RR ROM seems to be working fine for you, why don't you just this? I personally have no interest in porting another ROM. I don't even use half the features LineageOS offers on top of stock Android. My focus is on creating a stable ROM and being able to regularly pull upstream security fixes. That being said, all my work is published on my Github account, so anybody who's interested can pick it up and use it as a stepping stone for any other ROM.
New ROM 20170220
There's a new ROM available in the download section. Main improvements are fixing of the disappearing torchlight tile (thanks to the good people working on the Redmi2) and fixing of non-operational mobile data after disconnecting from WiFi. Also, I removed support for ZRAM, LZ4, swap, and F2FS. I don't think we need this (other msm8916 devices are living without it) and removing this brings the kernel closer to the stock kernel and hence improve long-term maintainability. I'm using this now as a daily driver and from my point of view it's quite stable.
EDIT: I messed up the GPS blobs in yesterday's release. There's a new ROM now in the download section that should have workiong GPS. Sorry for the inconvenience..
For those who are interested in details and for documentation purposes: on some msm8916 devices on Android 7, mobile data stops working after disconnecting from WiFi. There a few bug reports on LineageOS's jira on this:
https://jira.lineageos.org/projects/BUGBASH/issues/BUGBASH-72
https://jira.lineageos.org/browse/BUGBASH-129
It seems that netmgrd occasionally crashes and leaves the RIL in an undefined state that doesn't allow for new mobile data connections to be established. The crashes are due to netmgrd freeing non-allocated memory (which jemalloc intercepts and causes the process to abort). As netmgrd is a proprietary Qualcom binary, there is no way to fix this in source. I've tried to use the netmgrd binary from other devices but that didn't help. So I ended up patching the binary and replacing the respective calls to the free function by NOPs. Obviously, this introduced a memory leak and we will have to watch this carefully over time. But at least for now this seems to fix the problem and the memory leak seems to be small.
ottmi said:
It seems that netmgrd occasionally crashes and leaves the RIL in an undefined state that doesn't allow for new mobile data connections to be established. The crashes are due to netmgrd freeing non-allocated memory (which jemalloc intercepts and causes the process to abort). As netmgrd is a proprietary Qualcom binary, there is no way to fix this in source. I've tried to use the netmgrd binary from other devices but that didn't help. So I ended up patching the binary and replacing the respective calls to the free function by NOPs. Obviously, this introduced a memory leak and we will have to watch this carefully over time. But at least for now this seems to fix the problem and the memory leak seems to be small.
Click to expand...
Click to collapse
Maybe it's a silly question, but where is that netmgrd binary from? Would it be possible to use the netmgrd binary from the 32 bits version of Nougat for the google seed?
Meanwhile, my attempts with [email protected] are failing: wifi and ril cannot even start. I will try some change looking at your tree
Sorry for not having tried your rom yet, but I am spoiled with your great CM13
siljaer said:
Maybe it's a silly question, but where is that netmgrd binary from? Would it be possible to use the netmgrd binary from the 32 bits version of Nougat for the google seed?
Click to expand...
Click to collapse
It's the 64bit binary from Crackling. I thought about trying the 32bit netmgrd from Seed, but it has quite a few dependencies in terms of libraries. I would probably have to replace the libraries as well which would mean that the version numbers of the 32bit and 64bit libraries would be different. I'm not sure whether that would contribute towards a more stable ROM
Anyway, the patched version seems to work fine for now. I didn't notice any growth in memory consumption of the netmgrd process, so the leakage is probably small..
New ROM 20170224
There was a problem in the previous ROM with occassional WCNSS subsystem (WiFi) crashes which also caused the BlueTooth stack to crash. Should be fixed now in the new build.
Hi ottmi,
gorgeous work! I just got this device, therefore i did not do excessive testing yet. In comparison to cm-13.0-20160902, the 14.1-20170221 seems to work better (e.g. camera is not crashing). I do have only one question: At least on my device, root can be only set to 'ADB' or 'disabled'. Is this a restriction of LineageOS?
Best Regards,
Jan
jan_100 said:
Hi ottmi,
gorgeous work! I just got this device, therefore i did not do excessive testing yet. In comparison to cm-13.0-20160902, the 14.1-20170221 seems to work better (e.g. camera is not crashing). I do have only one question: At least on my device, root can be only set to 'ADB' or 'disabled'. Is this a restriction of LineageOS?
Best Regards,
Jan
Click to expand...
Click to collapse
LineageOS requires rooting. It can be done in several ways, I chose to use the addon provided by them in the "extras" download section on the LineageOS website.
---------- Post added at 10:56 ---------- Previous post was at 10:50 ----------
ottmi said:
It's the 64bit binary from Crackling. I thought about trying the 32bit netmgrd from Seed, but it has quite a few dependencies in terms of libraries. I would probably have to replace the libraries as well which would mean that the version numbers of the 32bit and 64bit libraries would be different. I'm not sure whether that would contribute towards a more stable ROM
Anyway, the patched version seems to work fine for now. I didn't notice any growth in memory consumption of the netmgrd process, so the leakage is probably small..
Click to expand...
Click to collapse
I've read that Lenovo is planning to officially release Nougat for msm8916 G4... I hope they can provide updated BSP too...
Meanwhile, I switched to your new ROM. It's been a short time, but it looks even better than CM13
Thanks for your great work!
@siljaer
Thank you very much! I was not aware of that.
karabassssss said:
Guys, I'm about to donate my dead elephone trunk if anyone needs it.
it was in great condition but one day it just won't turn on anymore.
it showing charging process once connected to charger, but doesn't react on power button.
case and some other accessories such as spare new back cover can also be donated .
And thanks Ottmi and all other guys for this great rom that extending life of this device!
Click to expand...
Click to collapse
Hi karabassssss, I will appreciate so much if you could donate me your Trunk.
I need a new case and, more, I've broken it and the camera glass too but I don't reach to contact any assistance to do this work.
I live in Italy, close to Florence and logically I will pay for the shipping of the package. Please let me know, thanks
PS Many many thanks to @ottmi for your previous CM13 rom, in a couple days I will flash your new one too
Hi All
I created a custom rom for SM-T705, (fenris) its a very security aware project.
Unfortunately ALL the AOSP/Lineage offerings have no working fingerprint, bugs, or both so I was stuck with a TouchWiz base.
Now having worked it into something different and special I have come to the issue of security updates.
As research goes it seems Samsung only push monthly/quarterly updates to some selected devices, NOT MINE
https://security.samsungmobile.com/etc/qsmr_list.html
Any ideas on a way to proceed?
Obviously the entire rom is effectively proprietary, with much effort needed to decompile to source.
What I would like is to match Google's security patch level
I am doing a BlueBorne patch myself by decompiling the Bluetooth stack, but that's just 5 vunrabilities out of 40 odd just in September !
Hi all,
It's look very strange that before 2015 there was so low CVE declared for Android (Between 1 and 13).
In 2017 there was more than 800, and CVE was growing since Google started to publish officially his security updates (since August 2015).
https://source.android.com/security/bulletin/2015-08-01
For Exemple in 2013 the CVE-2013-6282 wasn't reported in Android section, but in Linux. Checkpoint listed this in the top CVE for Android ! https://blog.checkpoint.com/2013/12/10/the-2013-android-vulnerability-of-the-year/
And some vulnerability from this website are also missing : http://androidvulnerabilities.org/by/year/
So the view in cvedetails.com and vulnerabilitycenter.com isn't correct.
We need perhaps to add all Linux Kernel CVE to Android CVE to have a better view. (https://www.cvedetails.com/product/47/Linux-Linux-Kernel.html?vendor_id=33)
Did you know a better view with all CVE for Android?
Check here :
https://www.cvedetails.com/product/19997/Google-Android.html?vendor_id=1224
https://www.vulnerabilitycenter.com/#[email protected]
Thanks.
{
"lightbox_close": "Close",
"lightbox_next": "Next",
"lightbox_previous": "Previous",
"lightbox_error": "The requested content cannot be loaded. Please try again later.",
"lightbox_start_slideshow": "Start slideshow",
"lightbox_stop_slideshow": "Stop slideshow",
"lightbox_full_screen": "Full screen",
"lightbox_thumbnails": "Thumbnails",
"lightbox_download": "Download",
"lightbox_share": "Share",
"lightbox_zoom": "Zoom",
"lightbox_new_window": "New window",
"lightbox_toggle_sidebar": "Toggle sidebar"
}
LineageOS is a free, community built, aftermarket firmware distribution of Android 11, which is designed to increase performance and reliability over stock Android for your device.
LineageOS is based on the Android Open Source Project with extra contributions from many people within the Android community. It can be used without any need to have any Google application installed. Linked below is a package that has come from another Android project that restore the Google parts. LineageOS does still include various hardware-specific code, which is also slowly being open-sourced anyway.
All the source code for LineageOS is available in the LineageOS Github repo. And if you would like to contribute to LineageOS, please visit out Gerrit Code Review.
###########################################################
Note: This is the first time I am building a ROM. My initial plan was to build it just for personal use. But since it is stable, I decided to share it with whoever is interested. I am not sure how often I will be updating it. But, I will try to do it every month. I added LineageOS recovery even though I do not use it at all. It can be downloaded if desired.
What's working:
RIL (Calls, SMS, Data)
Wi-Fi
Bluetooth
NFC
Camera
Video Recording
Video Playback
Audio
Sensors
Flash
GPS
Vibration
Wifi Hotspot
Selinux enforcing
What's not working:
Nothing I am aware of.
Possible issue:
If phone does not connect to network, reset APN.
Go to settings->Mobile Network -> Advanced -> "Access point names" -> "3 dots" -> "Reset to default".
Flashing Instructions:
Copy Lineage zip to phone.
(Optional) Copy bit gapps to phone.
Boot TWRP
Backup things you want to keep.
Tap Install -> Select LineageOS zip (and optionally, gapps)
Swipe to flash
Reboot system now
First boot, especially with Gapps, may take a while.
Downloads:
LineageOS 18.1
Optional: Bit Gapps. This is the only gapps that has 32bit for android 11 AFAIK.
Optional: Lineageos recovery
Sources:
https://github.com/LineageOS
s5neolte lineage-18.1 branches
Fincer branch : android_device_samsung_s5neolte_lineageOS
XDADevDB Information
[ROM][UNOFFICIAL][s5neolte][SM-G903F][11] LineageOS 18.1, ROM for the Samsung Galaxy S5 Neo
Contributors
The authors and maintainers of s5neolte gerrit branch PixelBoot, Stricted, danwood76, Borduni, Fincer
ROM OS Version: Android 11
ROM Kernel: Linux 3.10.x
Based On: LineageOS
Version Information
Status: Testing
Created 2021-06-16
Last Updated 2021-11-28
Changelogs
13-Sep-2021
- September security update
- Update Lineage sources.
11.08.2021
- August security update.
08.07.2021
- July security update
- Update Lineage sources.
- NFC fix applied. Thanks @Fincer
17.06.2021
- Added "Night Light" to display settings.
16.06.2021
- Initial release
Reserved
For now i cant test it cause i had to put back the latest stable official rom from Samsung on this spare phone, but, good work, keep it up. I'll try it for sure soon or later.
Maybe you could even try to reach out / join forces with Stricted and the others if that could simplify all of you guys' work on the roms. Idk, just saying.
Android 11!?!?! I was surprised that the S5 Neo got Android 10 and thought there was now way it would get Android 11, but I guess I was wrong. I wish I could test the rom, but the display on my S5 Neo is completely dead. RIP.
NFC without function, and the ROM feels a bit laggy, Pico GApps installed. Anyways, nice giveaway.
0LDST4R said:
NFC without function, and the ROM feels a bit laggy, Pico GApps installed. Anyways, nice giveaway.
Click to expand...
Click to collapse
NFC issue might be caused by the final 2 commits in the device tree.
s5neolte: build nfc hal from source · LineageOS/[email protected]
Change-Id: Ief7ef8f2a597b1a978ea4b0ec4e41391cec03a99
github.com
s5neolte: remove nfc manifest entry · LineageOS/[email protected]
* its a vintf manifest fragment now Change-Id: Ie81a0a3d7eb690fccb6987f16250d1c57cb1e8cd
github.com
The new NFC HAL doesn't allow updating the firmware. It fails on the A3 and A5.
JMek said:
For now i cant test it cause i had to put back the latest stable official rom from Samsung on this spare phone, but, good work, keep it up. I'll try it for sure soon or later.
Maybe you could even try to reach out / join forces with Stricted and the others if that could simplify all of you guys' work on the roms. Idk, just saying.
Click to expand...
Click to collapse
We have already completed the 11 bringup. This thread is really just a build of that work.
Regards,
Danny
I have got NFC working (s5neolte/Lineage OS 18.1), see my GitHub repository for details. After all, minor tweaks applied to current NFC [email protected] file and SELinux policy seem to be enough.
Fincer said:
I have got NFC working (s5neolte/Lineage OS 18.1), see my GitHub repository for details. After all, minor tweaks applied to current NFC [email protected] file and SELinux policy seem to be enough.
Click to expand...
Click to collapse
Thanks. I built a new version with NFC working. I see there is a commit in that branch that should enable call recording. I can't find the option in my phone though. It is maybe due to regional restrictions.
lallolu said:
Thanks. I built a new version with NFC working. I see there is a commit in that branch that should enable call recording. I can't find the option in my phone though. It is maybe due to regional restrictions.
Click to expand...
Click to collapse
Glad to hear . Call recording option should activate/be visible only during phone calls. Have you tested that?
Fincer said:
Glad to hear . Call recording option should activate/be visible only during phone calls. Have you tested that?
Click to expand...
Click to collapse
Yes, I tested it by initiating and later receiving a call. But recording option did not show up in either case.
lallolu said:
Yes, I tested it by initiating and later receiving a call. But recording option did not show up in either case.
Click to expand...
Click to collapse
Yeah, you are right. There are two relevant Dialer source java files which seem to dictate whether to show or hide the record option. The source code can obviously be patched.
packages/apps/Dialer/java/com/android/incallui/call/CallRecorder.java
- function canRecordInCurrentCountry() (lines 97-109) returns a boolean value
packages/apps/Dialer/java/com/android/incallui/CallButtonPresenter.java
- boolean variable showCallRecordOption, line 565, which gets its value from canRecordInCurrentCountry() function
- I assume showCallRecordOption dictates whether to show or hide recording button
I think one can simply replace lines 565-566 in CallButtonPresenter.java:
Java:
final boolean showCallRecordOption = recorder.canRecordInCurrentCountry()
&& !isVideo && call.getState() == DialerCallState.ACTIVE;
with
Java:
final boolean showCallRecordOption = !isVideo && call.getState() == DialerCallState.ACTIVE;
Bikeboy200 said:
Android 11!?!?! I was surprised that the S5 Neo got Android 10 and thought there was now way it would get Android 11, but I guess I was wrong. I wish I could test the rom, but the display on my S5 Neo is completely dead. RIP.
Click to expand...
Click to collapse
I was also surprised, I thought 10 would be the absolute max for the S5 Neo.
Fincer said:
I have got NFC working (s5neolte/Lineage OS 18.1), see my GitHub repository for details. After all, minor tweaks applied to current NFC [email protected] file and SELinux policy seem to be enough.
Click to expand...
Click to collapse
I have had a quick look over your changes.
The NFC sepolicy stuff doesn't look right to me (it may work but there is probably a simpler/correct way to fix it). I am guessing that an NFC file was incorrectly labelled, what were the original denials you were getting? I could probably fix our SEPolicy properly. It may be that Jan was in permissive when he made the original commits (I have usually taken care of the SEPolicy stuff).
The "patch_tcpsockettracker-crash.patch" fudges round a kernel bug which I should really get round to fixing, I think it is only a few picks (I might take a look at it tomorrow).
BTW running "device/samsung/universal7580-common/extract-files.sh" on an S5NEO stock firmware will probably break stuff, we use the A510F nougat as the source of the common files (our kernel is also based on the A510F). Running the extract scripts from the latest LOS version should work fine but it is actually better to simply use themuppets repo as that has our 18.1 changes already.
As you gathered the call recording feature is disabled in a lot of countries due to legality. For example it is illegal in Germany, Sweden, and lots of other countries.
Also if you fix anything you can always push your changes to gerrit and we can review/merge
Kind regards,
Danny
danwood76 said:
I have had a quick look over your changes.
The NFC sepolicy stuff doesn't look right to me (it may work but there is probably a simpler/correct way to fix it). I am guessing that an NFC file was incorrectly labelled, what were the original denials you were getting? I could probably fix our SEPolicy properly. It may be that Jan was in permissive when he made the original commits (I have usually taken care of the SEPolicy stuff).
The "patch_tcpsockettracker-crash.patch" fudges round a kernel bug which I should really get round to fixing, I think it is only a few picks (I might take a look at it tomorrow).
BTW running "device/samsung/universal7580-common/extract-files.sh" on an S5NEO stock firmware will probably break stuff, we use the A510F nougat as the source of the common files (our kernel is also based on the A510F). Running the extract scripts from the latest LOS version should work fine but it is actually better to simply use themuppets repo as that has our 18.1 changes already.
As you gathered the call recording feature is disabled in a lot of countries due to legality. For example it is illegal in Germany, Sweden, and lots of other countries.
Also if you fix anything you can always push your changes to gerrit and we can review/merge
Kind regards,
Danny
Click to expand...
Click to collapse
To me, looking at @Fincer's commits adding the SELinux rules, they seem like they've just been copied right out of a different device tree.
I'm using the new open source Samsung NFC HAL on my own LineageOS 17.1 builds. To address the SELinux denials that I got with it, I labelled its service in the sepolicy in my commit here: https://github.com/TALUAtGitHub/and...mmit/914f6ec44657732de3562fd1b259d3ad1b8fcf95 ...and so, your guess that a file, which happens to be the NFC HAL service, is incorrectly labelled is correct. Labelling it with the correct label is absolutely all that's necessary.
Speaking of NFC, I've got an issue with my S5 Neo where NFC only works with another phone that I've tested it with. It doesn't work with any of the NFC tags/cards that I've tested, and this issue exists with both the new open source NFC HAL and the old NFC HAL. I don't know if that issue exists on the stock firmware as I never tested NFC on it. Has anyone got similar issues?
On the topic of call recording, to enable it (for whichever regions it's set to be allowed in, of course), all that would be required is this change: https://github.com/TALUAtGitHub/and...mmit/11448569ef5d1358bae1e6abbfce9d37200f6887 I haven't tested it myself yet. Changes outside of device-specific trees, as have been shared for it, should always be avoided if at all possible.
So much technical stuff in this last posts. Very interesting for me to read all these things, and even more interesting how many people are active in development with this device. I'm just only the " typical enduser " with a fraction of all your knowledge, but i'm very happy to benefit from that.
Greetz, respect, and thanks.
_-_-_-_-_
0LDST4R
-_-_-_-_-
Thanks for commenting!
I am pretty sure there's room for fixes in my SEPolicy. What comes to NFC, I haven't copied all SEPolicy rules from "other device trees", although there are some rules used from other device tree sources (I know, rules should be evaluated, simply haven't had time for that). In most NFC rules, however, I simply allowed capabilities which did not cause any avc denials in my logs. I am pretty sure my SEPolicy might be too loose and should be more restrictive, and I am grateful if anyone like to improve it. I don't have list of original denials, but the current NFC SEPolicy rule set is mostly based on those.
Running '"device/samsung/universal7580-common/extract-files.sh" has not caused any issues on my S5 Neo, well, so far.
The patch file for TCP socket tracker crashing was one I found once I analyzed my logcat output and was seeing constant messages of the tracker process crashing. I don't like unnecessary crashes.
My personal opinion for call recording is that anyone who uses patches or workarounds to enable the feature takes legal and personal responsibility of doing so, as well.
TALUAtXDA said:
To me, looking at @Fincer's commits adding the SELinux rules, they seem like they've just been copied right out of a different device tree.
I'm using the new open source Samsung NFC HAL on my own LineageOS 17.1 builds. To address the SELinux denials that I got with it, I labeled it in the sepolicy in my commit here: https://github.com/TALUAtGitHub/and...mmit/7e1325429647c7420e02d106bfdd0477b44888e4 I also have this related commit: https://github.com/TALUAtGitHub/and...mmit/fe5d4e253c5310523e66c4ff2c84424d5beee424 That's absolutely all that's necessary.
Speaking of NFC, I've got an issue with my S5 Neo where NFC only works with another phone that I've tested it with. It doesn't work with any of the NFC tags/cards that I've tested, and this issue exists with both the new open source NFC HAL and the old NFC HAL. I don't know if that issue exists on the stock firmware as I never tested NFC on it. Has anyone got similar issues?
As for call recording, to enable it, all that would be required is this change: https://github.com/TALUAtGitHub/and...mmit/95dfe486a5cca4b5fe3c9721d927de4aca772e7f I haven't tested it myself yet. Whether or not the call recording option becomes available with it would depend on if call recording is marked as being illegal in your country. Changes outside of device-specific trees should always be avoided if at all possible.
Click to expand...
Click to collapse
That sepolicy change looks correct. Are you happy for me to cherry-pick your patch and upload to gerrit? (Or you could do that yourself?)
The moving config to vendor patch isn't quite right for us, I will do a correct version with your authorship if you are happy? (also upload to gerrit). We like to keep the config file names the same as on stock.
To test the NFC I use the android CTS verifier. You can emulate payments and all NFC functions using that.
I will also cherry-pick your call recording overlay patch, not really sure how that got dropped as I remember we had that a few years ago.
Thanks for your input.
Kind regards,
Danny
danwood76 said:
That sepolicy change looks correct. Are you happy for me to cherry-pick your patch and upload to gerrit? (Or you could do that yourself?)
Click to expand...
Click to collapse
Alright. Yes, you can upload it to gerrit. I don't know how to upload patches to gerrit yet, so it would be better for you to do it.
danwood76 said:
The moving config to vendor patch isn't quite right for us, I will do a correct version with your authorship if you are happy? (also upload to gerrit). We like to keep the config file names the same as on stock.
Click to expand...
Click to collapse
I've edited that commit through a rebase myself, and removed the change of the filename: https://github.com/TALUAtGitHub/and...mmit/c98d51d42c92af13bcfb8cb5157fcde077d9bdad
danwood76 said:
To test the NFC I use the android CTS verifier. You can emulate payments and all NFC functions using that.
Click to expand...
Click to collapse
I see. I think the CTS tests for NFC would pass. I just have the issue that I've described on my specific S5 Neo with both the new and old NFC HAL, and it looks like no one else has any similar issues. I think something might just be wrong with the NFC coil in the battery that I'm currently using, which really needs to be replaced, anyway.
danwood76 said:
I will also cherry-pick your call recording overlay patch, not really sure how that got dropped as I remember we had that a few years ago.
Click to expand...
Click to collapse
Okay. By the way, I've also edited that commit through a rebase to remove the call_recording_audio_source overlay, so that the default audio source, 1, is used. With audio source 4 which was set to be used through that overlay, call recording fails, with the following log messages from logcat:
Code:
[...]
07-15 09:48:02.103 3564 6980 E APM::AudioPolicyEngine: getDeviceForInputSource() no default device defined
07-15 09:48:02.103 3564 6980 W APM_AudioPolicyManager: getInputForAttr() could not find device for source 4
07-15 09:48:02.103 3564 6980 E AudioFlinger: createRecord() getInputForAttr return error -22
07-15 09:48:02.103 3594 5636 E IAudioFlinger: createRecord returned error -22
07-15 09:48:02.103 3594 5636 E AudioRecord: createRecord_l(0): AudioFlinger could not create record track, status: -22
07-15 09:48:02.104 3594 5636 E StagefrightRecorder: audio source is not initialized
07-15 09:48:02.104 6728 6746 E MediaRecorder: start failed: -2147483648
07-15 09:48:02.145 6728 6746 W CallRecorderService: Could not start recording
[...]
With audio source 1, it works fine.
danwood76 said:
Thanks for your input.
Kind regards,
Danny
Click to expand...
Click to collapse
You're welcome.
This is LineageOS 19.1, which is based on Android 12L, for the Samsung Galaxy S5 Neo, codenamed s5neolte, with models SM-G903F, SM-G903W, and SM-G903M.
LineageOS doesn't need much of an introduction - It's a well-known custom firmware/Android distribution.
I've picked up with these builds from @Radplay, as the original maintainer who brought up 19.1 for the S5 Neo.
His builds made use of my sources. Very long ago, I was maintaining for my own personal use, did bringup for 19.1, and was planning to start releasing public builds myself. But then my S5 Neo's screen stopped working, so I couldn't continue, and a few bugs I wanted to look into and fix went unfixed. Now that I've got a new screen, I've fixed those bugs, and can now release my own public builds.
Note on LineageOS 19.1/Android 12 usability - For those needing Google apps: Do not use heavy Google apps packages, as otherwise, you WILL have severe performance issues. Instead, use the most minimal variant of your chosen package. For example, for OpenGapps (no longer maintained officially, with no Android 12L packages, so use @ipdev's latest unofficial build available here), that is the pico variant.
Also, make sure to use 32-bit ARM packages, not 64-bit ARM64 ones, since these devices unfortunately don't run 64-bit Android despite being 64-bit capable.
Build download
From 20230625 with security patch level 20230605: https://drive.google.com/file/d/1KAvGHhp61zUJMAbnaasxrWnSTM2nNqBD/
Recovery to use
Use my unofficial TWRP build:
Image: https://drive.google.com/file/d/1dIgSDgPUBqben7tvylwL7zyhT9HeOAJ3/
Tar for Odin for the AP slot: https://drive.google.com/file/d/1guVj-Ghcneu9SR3ff3clLp9170CfJbNT/
This build is built from newer sources than the official TWRP builds and has a kernel built from the same sources as these LineageOS builds, so using it instead of an official one is preferable.
The official 3.7.0 TWRP build apparently might not work, while this is a working 3.7.0 build.
Folder for builds
Along with the current build, it contains a text file with the SHA256 checksum for it, and a folder which will contain some previous builds: https://drive.google.com/drive/folders/1jvNM__De4VASNoYmf8xjDZEMVmYSlr-3
Changelogs
Build for 20230625 (this changelog picks up from @Radplay's last build):
Latest changes from LineageOS, including the 20230605 Android security updates.
Bluetooth calling has been fixed.
Linaro's new SLSI BSP (Board Support Package, containing sources for HWC and some other stuff) sources are now used - Much more up-to-date than the previously used sources, and there's possibly a small improvement in performance.
Fixed an issue where the speaker would be slightly quieter than expected, and there is possibly slightly distorted audio at full volume from the headphone jack while playing media.
RIL blobs updated from Samsung's T515XXU8CVL1 firmware - Fixes an issue where, after enabling airplane mode, "Service status" under "SIM status" in "About phone" in settings wouldn't report "Radio off", meaning the cellular modem might still have been active in some way.
Some miscellaneous cleanups have been done.
Some security patches have been applied to the kernel.
The Wireguard kernel module has been removed from the kernel as it causes kernel panics. The userspace Wireguard implementation remains usable.
Previous releases
None for now.
Known issues and workarounds/fixes (if any)
Issue 1 - No VoLTE support: VoLTE currently can't work on any Samsung devices due to Samsung's proprietary implementation in stock firmwares not working on AOSP.
Issue 2 - Possible low volume and echoing while calling on speakerphone: There may be low mic volume issues and echoing that can be heard by the person you're calling, both while using the speaker.
These issues are supposed to be fixed by some blobs called "Lifevibes". They were added in official LineageOS 18.1 sources, but I decided to get rid of them as they completely destroy audio quality. As a workaround, the earpiece or headphones should be used instead.
If anyone wants them, I could have a way to bring them back as a compromise without including them in my builds, please do ask if so.
Some additional info if anyone is interested:
The lifevibes blobs apply insanely heavy noise gating, to get around the noisiness of this phone's microphones, and also heavily downsamples recorded audio in some way. Both processes result in horrible sounding recorded audio - The downsampling makes it sound lower fidelity than AM radio, and the noise gating is excessive to the point of annoying audible artifacts, and it may also get rid of audio content that can still be made out but is just above the noise floor of the mics. That ruined a mission-critical recording for me. I'd rather just take the noisiness.
Something notable is that with Android 12, encrypted data can't be decrypted in TWRP recovery. That problem can only be fixed within TWRP, but with the fixes only being in Android 12L TWRP sources, which we can't build our TWRP builds from due to issues, it continues to exist.
To report further issues, get a log from logcat and dmesg. If you're unsure on how to get either, there's good documentation out there for how to do so.
Sources
A manifest containing all of the necessary repositories to make builds is in the repository here on branch lineage-19.1.
Thanks to:
The previous maintainers, Stricted and danwood76, for all of the previous work for these devices.
The Lineage team - for the Android distribution itself.
...and everyone else who has worked on anything that is in use, such as device tree changes.
Some extra stuff:
I've now fixed almost all of the remaining fixable issues that I know of after extensive testing, making my build almost bugless. But if anyone does come across issues besides those I've mentioned in my original post, do report them.
For anyone here who was following @Radplay's thread until the end, on the stuff about credit, while it did end up being given very prominently, I think it's worth mentioning that it wasn't such a big deal. I suppose I overreacted somewhat. Everything is fine at the end of the day.
I'm going to try releasing a new build around every month.
Enjoy.
Nice to see this version released, good job
Just installed over the "other" one
Rocking!
did a clean install, twrp and the rom, all seems to be working well.
Thank you!